Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react] Add globalCss processor #31

Merged
merged 9 commits into from
Jun 1, 2024
Merged

[react] Add globalCss processor #31

merged 9 commits into from
Jun 1, 2024

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Apr 22, 2024

closes #9

Material UI components need this.

@mnajdova
Copy link
Member

In general, the API looks good. Can we create a PR on the Material UI repo to see what the transition from the current GlobalStyles component would look like?

@mnajdova mnajdova added the new feature New feature or request label Apr 23, 2024
@mnajdova mnajdova changed the title Add globalCss processor [react] Add globalCss processor Apr 23, 2024
@siriwatknp
Copy link
Member Author

In general, the API looks good. Can we create a PR on the Material UI repo to see what the transition from the current GlobalStyles component would look like?

Here it is > mui/material-ui#42431

@brijeshb42
Copy link
Contributor

Will the README for the API be updated separately or should it be done in this PR itself ?

@siriwatknp
Copy link
Member Author

Will the README for the API be updated separately or should it be done in this PR itself ?

Good point, I will update this PR.

@siriwatknp
Copy link
Member Author

@brijeshb42 Please check 1f968f0

README.md Outdated Show resolved Hide resolved
Co-authored-by: Brijesh Bittu <[email protected]>
Signed-off-by: Siriwat K <[email protected]>
@siriwatknp
Copy link
Member Author

@mnajdova @brijeshb42 Can I get an approval for this? It's blocking mui/material-ui#42431

@siriwatknp siriwatknp merged commit f014111 into master Jun 1, 2024
17 checks passed
@siriwatknp siriwatknp deleted the feat/global-styles branch June 1, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[core] Support the Global Styles API
3 participants